Jump to content

MediaWiki talk:Gadget-modrollback.js

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia

Possible issues

[edit]

Just looking at the code, I suspect that unescape might be causing problems with some usernames (encode/decodeURIComponent is usually better) and wgServer + '/wiki/' is not compatible with secure login. —AlexSm 22:14, 23 June 2008 (UTC)[reply]

Compare to m:MediaWiki:Gadget-modrollback.js  — Mike.lifeguard | @en.wb 02:48, 7 November 2008 (UTC)[reply]
I've fixed the bugs mentioned by AlexSm (by using wgScript and by not decoding the username at all), and tweaked the AJAX code to use sajax_init_object() from ajax.js for wider browser compatibility. Still, the script has other issues. One is that it only affects the rollback links in diffs, not in user contribs, article histories or elsewhere. Another is that it doesn't check if the rollback succeeded. One way to fix this would be to use API rollback. Another would be to change the script not to modify the links at all, but simply to trigger on the rollback result page (which is easily identifiable using wgAction == "rollback", and appears to contain a diff table if and only if the rollback succeeded). —Ilmari Karonen (talk) 16:19, 11 November 2008 (UTC)[reply]

Protected edit request on 18 July 2014

[edit]

Please remove "&smaxage=21600&maxage=86400" as in mw:Special:Diff/1068457. These parameters are not necessary. Helder.wiki 16:06, 18 July 2014 (UTC)[reply]

 Done Ruslik_Zero 19:28, 18 July 2014 (UTC)[reply]